Feature/image saving callback #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
July 18, 2024 14:56
benjijamorris
requested review from
hughes036,
saeliddp,
ritvikvasan and
yrkim98
ritvikvasan
previously approved these changes
Jul 19, 2024
| # stages: ["predict"] | ||
| # save_input: False | ||
| # training | ||
| saving: |
There was a problem hiding this comment.
what is the saving key here? Shouldnt callbacks just be a list of callbacks?
There was a problem hiding this comment.
they all have a key :
| if stage != "predict" | ||
| else None, | ||
| "input": self._postprocess( | ||
| batch[self.x_key], img_type="input", n_postprocess=n_postprocess |
There was a problem hiding this comment.
in the config I broke down postprocesssing by whether it's applied to the input/target/prediction
added 2 commits
July 19, 2024 11:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
save-inputargument from im2im headsPLUGIN DEVS
This should preserve format except for saved out image filenames (which I don't think we're relying on anymore?) Feel free to chime in if you have more questions/tests I should run.
Before submitting
pytestcommand?pre-commit run -acommand?Did you have fun?
Make sure you had fun coding 🙃