Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update transforms #293

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Feature/update transforms #293

merged 4 commits into from
Sep 25, 2023

Conversation

benjijamorris
Copy link
Contributor

  • add non-dictionary resizing transform
  • update cropping to allow cropping when patch size is equal to image size

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@ritvikvasan
Copy link
Member

what's the advantage of this transform over using something like torchio.transforms.Resize?

@benjijamorris
Copy link
Contributor Author

benjijamorris commented Sep 22, 2023

for e.g. transfer function, we don't know the target shape when creating the transform object, we just know the ratios we want to resize by. I haven't the torchvision and torchio resizes don't seem to work for that case, but while trying to justify this I found monai's zoom function. I'll delete these 👍

@ritvikvasan
Copy link
Member

ok makes sense! sounds good

@benjijamorris benjijamorris merged commit a9be90c into main Sep 25, 2023
1 of 8 checks passed
@benjijamorris benjijamorris deleted the feature/update_transforms branch September 25, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants