Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/remove-czi-install-pattern #376

Merged
merged 3 commits into from
Feb 22, 2022
Merged

Conversation

evamaxfield
Copy link
Collaborator

Description

Similar to the LIF and BioFormats install pattern removals, CZI has been deemed GPL licensed by legal people. We are mirroring the install pattern here and documenting the license in the README.

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [gh-], adds tiff file format support
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@evamaxfield evamaxfield added documentation Improvements or additions to documentation admin Various administrative tasks for the package labels Feb 16, 2022
@evamaxfield evamaxfield self-assigned this Feb 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #376 (1137c4e) into main (389ba1d) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   93.71%   93.57%   -0.14%     
==========================================
  Files          47       47              
  Lines        3580     3580              
==========================================
- Hits         3355     3350       -5     
- Misses        225      230       +5     
Impacted Files Coverage Δ
aicsimageio/formats.py 100.00% <ø> (ø)
aicsimageio/readers/czi_reader.py 94.88% <ø> (-0.35%) ⬇️
aicsimageio/tests/conftest.py 92.30% <0.00%> (-3.85%) ⬇️
aicsimageio/tests/readers/test_czi_reader.py 96.66% <0.00%> (-3.34%) ⬇️
aicsimageio/readers/ome_tiff_reader.py 98.16% <0.00%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 389ba1d...1137c4e. Read the comment docs.

@evamaxfield evamaxfield merged commit 21ac821 into main Feb 22, 2022
@evamaxfield evamaxfield deleted the admin/remove-czi-install-pattern branch February 22, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Various administrative tasks for the package documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants