Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin/move-test-resources-hash-to-text-file #202

Merged
merged 1 commit into from
Feb 3, 2021
Merged

admin/move-test-resources-hash-to-text-file #202

merged 1 commit into from
Feb 3, 2021

Conversation

evamaxfield
Copy link
Collaborator

@evamaxfield evamaxfield commented Feb 3, 2021 •
edited
Loading

Description

To enable @tlambert03 specified access to our test resources so that ome-types integration tests will always have matching resources as the current stable instead of latest in the bucket.

ome-types PR introducing aicsimageio tests: tlambert03/ome-types#77

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [Fix release #12], adds tiff file format support
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@evamaxfield evamaxfield added the admin Various administrative tasks for the package label Feb 3, 2021
@evamaxfield evamaxfield self-assigned this Feb 3, 2021
AetherUnbound
AetherUnbound approved these changes Feb 3, 2021
View reviewed changes
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tlambert03
Copy link
Collaborator

Thanks!

@evamaxfield evamaxfield merged commit f8ec41a into main Feb 3, 2021
@evamaxfield evamaxfield deleted the admin/move-test-resources-hash-to-single-file branch February 3, 2021 04:32
@heeler
Copy link
Member

heeler commented Feb 3, 2021

Just looked at the changes. Makes sense what you've done. Nice sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AetherUnbound AetherUnbound AetherUnbound approved these changes

@heeler heeler Awaiting requested review from heeler

@toloudis toloudis Awaiting requested review from toloudis

Assignees

@evamaxfield evamaxfield

Labels
admin Various administrative tasks for the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evamaxfield @tlambert03 @heeler @AetherUnbound