Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table with Fig TFE Links #38

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Table with Fig TFE Links #38

merged 3 commits into from
Nov 20, 2024

Conversation

chantelleleveille
Copy link
Contributor

@chantelleleveille chantelleleveille commented Nov 15, 2024

Goal:

Add markdown table containing links for each figure and a direct link to explore the result in TFE.

Point to it from the main readme

Preview:
Screen Shot 2024-11-15 at 10 48 11 AM

@chantelleleveille chantelleleveille marked this pull request as ready for review November 15, 2024 00:24
@jcass11
Copy link
Collaborator

jcass11 commented Nov 15, 2024

Yay looks amazing! Thanks for taking the action to transfer the spreadsheet into a beautiful markdown table with documentation. I'm so excited about it!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/TFE_links.md Outdated Show resolved Hide resolved
docs/TFE_links.md Outdated Show resolved Hide resolved
@jcass11
Copy link
Collaborator

jcass11 commented Nov 15, 2024

@cfrick13 on the google sheet version I made (its a tab on the nuc morph to-do spreadheer) I included placeholders for including the example trajectories from your S10 dip figure. Once those features are added to public TFE we can move those into this markdown table too!

Copy link
Collaborator

@pgarrison pgarrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! I tested all the links in the table and they all load things in TFE successfully. Also the link from the README.md to the TFE_links.md works

@chantelleleveille chantelleleveille added this pull request to the merge queue Nov 20, 2024
Merged via the queue into dev with commit 73f37ae Nov 20, 2024
1 check passed
@chantelleleveille chantelleleveille deleted the tfe_links branch November 20, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants