Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number workflows #37

Merged
merged 15 commits into from
Nov 20, 2024
Merged

Number workflows #37

merged 15 commits into from
Nov 20, 2024

Conversation

chantelleleveille
Copy link
Contributor

@chantelleleveille chantelleleveille commented Nov 14, 2024

Main Goal: Update workflow names to indicate which figure in the paper they generate.

For review:

  • please confirm if you like this numbering/naming convention
  • @cfrick13 Please double check s2 and s3 and s18. I did not rename your base workflow files because I wasn't 100p sure what came from where!
  • s17 I think is a code free figure? or can you confirm what workflow it is associated with.

Bonus one line bug fix:

  • Full tracks dataframe was not sorted by index sequence and it was causing plots to look crazy!

All workflows succeeded!

Well except these two but they fail for known reasons (new density metric needs to be updated) and will be addressed in a different PR!

figure_s12_feeding_control (178.8s) (23.6GB). KeyError "['2d_area_nuc_cell_ratio'] not in index". See stack trace above.
figure_s6_s16_inhibitors (92.0s) (10.7GB). KeyError "['2d_area_nuc_cell_ratio'] not in index". See stack trace above.

@chantelleleveille chantelleleveille marked this pull request as ready for review November 14, 2024 23:07
@jcass11
Copy link
Collaborator

jcass11 commented Nov 15, 2024

  • Checked all the new referenced fig numbers and they all match the right figures ✅
  • Naming convention and organization all looks good to me
  • Yes I believe S17 is code-free
  • Thanks for the bug fix!

Copy link
Collaborator

@jcass11 jcass11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like @chantelleleveille is going to run all workflows so I am approving without running. Thank you!

Copy link
Collaborator

@pgarrison pgarrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@chantelleleveille chantelleleveille added this pull request to the merge queue Nov 20, 2024
Merged via the queue into dev with commit 48e19e4 Nov 20, 2024
1 check passed
@chantelleleveille chantelleleveille deleted the number_workflows branch November 20, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants