Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in github actions #54

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Fix tests in github actions #54

merged 7 commits into from
Mar 28, 2024

Conversation

pgarrison
Copy link
Collaborator

@pgarrison pgarrison commented Mar 22, 2024

Purpose

The "test and lint" github action is failing, make it unsuitable for running on pull requests.

Changes in this PR

  • Fix the syntax of the github workflow
  • Comment out the lint section of the workflow (it is failing)
  • Remove part of the test from Bugfix/shape space test #52 that failed on MacOS
  • Pin github actions to specific hashes
  • Add dependabot configuration to keep github actions up to date

Settings changes I made in github

  • Prevent merges if status checks (tests) fail
  • Enable dependabot security updates (alerts and version updates were already enabled)

Testing

On this PR, I now get "All checks passed" and inspecting the action logs shows that the tests ran.

@pgarrison pgarrison force-pushed the feature/run-tests-in-ci branch from c0ef2cf to 5084305 Compare March 26, 2024 16:11
@pgarrison pgarrison force-pushed the feature/run-tests-in-ci branch from e2e66bd to d34f66e Compare March 26, 2024 16:26
@pgarrison pgarrison force-pushed the feature/run-tests-in-ci branch from d34f66e to 18be0ea Compare March 26, 2024 16:31
@pgarrison pgarrison marked this pull request as ready for review March 26, 2024 16:46
@pgarrison pgarrison requested review from vianamp, anl and djeung March 26, 2024 16:47
@pgarrison pgarrison merged commit c894c93 into master Mar 28, 2024
10 checks passed
@pgarrison pgarrison deleted the feature/run-tests-in-ci branch March 28, 2024 19:22
@pgarrison pgarrison mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants