Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all notebooks to scripts #55

Closed
wants to merge 32 commits into from

Conversation

ritvikvasan
Copy link
Collaborator

@ritvikvasan ritvikvasan commented Nov 22, 2024

This PR does a few things

  1. Delete notebooks fig2-7
  2. Add run_embeddings script to compute embeddings
    e.g. python src/br/analysis/run_embeddings.py --save_path "./outputs/" --sdf False --dataset_name "pcna" --batch_size 5 --debug False
  3. Add run_features script to compute features
    e.g. python src/br/analysis/run_features.py --save_path "./outputs/" --embeddings_path "./morphology_appropriate_representation_learning/model_embeddings/pcna" --sdf False --dataset_name "pcna"
  4. Add run_analysis script to run all analysis.
    e.g. python src/br/analysis/run_analysis.py --save_path "./outputs_pcna/" --embeddings_path "./morphology_appropriate_representation_learning/model_embeddings/pcna" --dataset_name "pcna" --run_name "Rotation_invariant_pointcloud_jitter" --sdf False
  5. Add run_drugdata_analysis script to run drug data perturbation detection analysis
    python src/br/analysis/run_drugdata_analysis.py --save_path "./outputs_npm1_perturb/" --embeddings_path "./morphology_appropriate_representation_learning/model_embeddings/npm1_perturb/" --dataset_name "npm1_perturb"

To test these runs, you will need a local copy of the morphology_appropriate_representation_learning folder with the preprocessed data. This dataset currently lives here

/allen/aics/modeling/ritvik/projects/latest_clones/benchmarking_representations/morphology_appropriate_representation_learning/

Fatwir Mohammed and others added 30 commits November 20, 2024 09:56
…y script that essentially is used to compute features which will then be used to plot the figures!
Reverted this change!
@pgarrison
Copy link
Collaborator

A lot of these changes appear to be due to running a linter or other pre-commit hooks.

  • Can we split this PR up into (1) the first 5+ commits that include running the linter and (2) the changes related to moving notebooks to .py files?
  • For the linting PR, can you share the configuration used so that we can all run it the same way?

The github action identified that pyproject.toml and pdm.lock are out of sync. Run pdm lock --update-reuse` to fix this.

@ritvikvasan
Copy link
Collaborator Author

@fatwir will work on splitting this PR up. Im going to work on another PR for the missing analysis in this repo

The linting config is here - https://github.com/AllenCell/benchmarking_representations/blob/main/.pre-commit-config.yaml

@ritvikvasan ritvikvasan marked this pull request as draft November 22, 2024 22:53
@fatwir
Copy link
Collaborator

fatwir commented Nov 22, 2024

So all the commits upto 396b9d00d033e854f339ee10126d7b0b9853bac0 are in one PR and the other will be in another PR right?

@fatwir fatwir changed the base branch from main to Pre-Commit-analyses November 23, 2024 00:36
@pgarrison
Copy link
Collaborator

@ritvikvasan closing this in favor of #58. Please take over that PR

@pgarrison pgarrison closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants