-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/enforce model trained once #519
Conversation
428af07
to
eac82b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so I understand correctly, this is to ensure that after someone has trained a model through the plugin, they do not mistakenly retrain again. So this disables the tab for training and puts them directly to the prediction tab?
How does this work for iterative training? Say I trained my model, I run prediction, results look good. Now I want to retrain again on new data, but load the model I just trained and continue training from there, do I need to close the Segmenter ml plugin since training is disabled? Or is it easy to just start a new run? Sorry for the weird phrasing, I hope this makes sense.
Good questions. I think it is to be in line with the existing workflow for newly trained models (which can't be iteratively trained, per the UX design). Allowing iterative training on the same model was going to open a can of worms in terms of populating the UI correctly and validating what is entered to be coherent with the earlier rounds of training (I think this was the reason - can you confirm @yrkim98 @thao-do ) The workflow that we ended up with (initially during a conversation with Susan) was that for every iteration of training, the user will create a new model based on the weights that they are 'iterating' on. So in your scenario, rather than doing additional training on Did I get it right @yrkim98 ? |
@yrkim98 @amilworks How about we discuss this @ standup? |
@hughes036 I think we'll still have to deal with that can of worm to a certain extent - we need to check with @benjijamorris if any UI input will be in conflict with the model weight being used (mainly the Patch size). Also, the Training tab was currently disabled in the existing model route since we couldn't quite get iterative training earlier on (I need to look back on the reasons why to see whether they're still a concern). This new addition to pull model weight is a first step toward allowing more than one case of iterative training. We'll need more discussion on this as there are a few things we might want to reassess. |
UI changes to enforce that the user can only train a model once. Will automatically switch to prediction tab and disable curation/training once plugin is able to verify a model was sucessfully trained.
Changes: