-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
390 mypy #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughes036
reviewed
Aug 12, 2024
hughes036
reviewed
Aug 12, 2024
hughes036
reviewed
Aug 12, 2024
hughes036
reviewed
Aug 12, 2024
src/allencell_ml_segmenter/core/q_runnable_manager/global_q_runnable_manager.py
Outdated
Show resolved
Hide resolved
hughes036
reviewed
Aug 12, 2024
hughes036
reviewed
Aug 12, 2024
hughes036
reviewed
Aug 12, 2024
hughes036
approved these changes
Aug 12, 2024
yrkim98
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was a huge refactor- thank you
Did you replace all instances of Dict
and List
with builtin types?
I replaced them where I saw them, but I wasn't specifically looking for it, so I'm sure a couple slipped by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#390 -- the goal of this PR is to add a type checker to our CI. We settled on
mypy
, which seems to be widely used and comes recommended by Philip.The changes related to adding
mypy
to CI are just intest_lint.yaml
andpyproject.toml
. The rest of the changes are fixing files so that they pass themypy
checks.The majority of type fixes fall into these categories:
None
type of variables that are typedOptional[<something>]
Qt.AlignTop
instead ofQt.AlignmentFlag.AlignTop
). Not sure why exactly this was working, but seems to be fine either way.