Simplify image loader signals #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughes036
reviewed
May 22, 2024
hughes036
reviewed
May 22, 2024
hughes036
reviewed
May 22, 2024
hughes036
reviewed
May 22, 2024
src/allencell_ml_segmenter/curation/curation_image_loader/curation_image_loader.py
Show resolved
Hide resolved
hughes036
reviewed
May 22, 2024
src/allencell_ml_segmenter/curation/curation_image_loader/curation_image_loader.py
Show resolved
Hide resolved
hughes036
reviewed
May 22, 2024
src/allencell_ml_segmenter/curation/curation_image_loader/curation_image_loader.py
Show resolved
Hide resolved
hughes036
reviewed
May 22, 2024
hughes036
reviewed
May 22, 2024
hughes036
reviewed
May 22, 2024
hughes036
reviewed
May 22, 2024
hughes036
reviewed
May 22, 2024
hughes036
reviewed
May 22, 2024
src/allencell_ml_segmenter/_tests/curation/curation_image_loader/test_curation_image_loader.py
Show resolved
Hide resolved
hughes036
reviewed
May 22, 2024
hughes036
approved these changes
May 23, 2024
saeliddp
force-pushed
the
314_enable_next_when_curr_ready
branch
from
1d550a6 to
db01496
Compare
yrkim98
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In addressing #314 , I decided to simplify our image loader signals. Before, we had three signals, one for signifying whether curr, prev, and next were finished loading. Now we just have one signal,
is_idlewhich is emitted when all images are done loading in the image loader.Changes
curation/curation_image_loader: modify signals in interface and implementations. Some significant work in the real implementation to address the newis_idlesignal.curation/curation_model.py: update the signals here to correspond with the image loader signals. Also added a 'start image loading' method to correspond with the loader as well.curation/main_view.py: update to listen and react to the new signalsTesting
Updated unit tests where necessary, manually tested.