Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash in Scope #388

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix a crash in Scope #388

merged 1 commit into from
Nov 11, 2024

Conversation

chrisib
Copy link
Collaborator

@chrisib chrisib commented Nov 11, 2024

Fix a crash in Scope where the max input voltage was being incorrectly treated as an integer

User report from Discord:

[...] scope crashes now (all other modules look ok) [...] Here's a sample crash log:

624: range expects an int value, got: 12.0
Traceback (most recent call last):
  File "bootloader.py", line 170, in main
  File "contrib/scope.py", line 92, in main
  File "contrib/scope.py", line 77, in read_max_disp_voltage
  File "europi.py", line 346, in read_position
  File "europi.py", line 216, in range
ValueError: range expects an int value, got: 12.0

@chrisib chrisib merged commit c164d4a into Allen-Synthesis:main Nov 11, 2024
3 checks passed
@chrisib chrisib deleted the fix-scope branch November 11, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants