Make the Docker Sandbox Stateful (e.g., keep track of all cded directories)
#597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
reviewed
Apr 2, 2024
| ) | ||
| self._attach_sockets() | ||
| self.stdin_stream.write("echo 'hello'\n".encode("utf-8")) |
|
A potentially better implementation at #847 |
|
Close due to the merge of #847 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve the issue discussed here by making the Docker Sandbox Stateful (e.g., keeping track of all
cded directories).The current draft solution (not working!) is built on
dockerpty, but i feel it is kinda tricky (may need more tweaks) to get it working since I'm not an expert in PTY :-(Will try to look into this in the next few days -- suggestions on how to proceed will be appreciated!