-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace browsergym with browsergym-core to reduce dependencies #5340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are now failing due to a missing dependency on "joblib". I expect that this was because joblib was included by browsergym, but it not explicitly included in our pyproject.toml file. We should also include a relevant version of joblib in pyproject.toml to adjust for this.
New OpenHands update |
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
@neubig Sorry, we can continue to fix it here, but just for discussion, have you seen this?
That PR is in the stage "thinking about" 😅 because:
So my current theory about how to fix this, is to move both the llama-index and evaluation groups tests to some other pipeline like we now have the integration tests one:
|
Hey @enyst , I indeed had not seen that. Apologies! I'll look through carefully when I have a moment. |
Closing in favor of #5242 |
This PR replaces the dependency on
browsergym
withbrowsergym-core
to reduce unneeded dependencies. The fullbrowsergym
package includes many additional dependencies that are not needed for our use case.Changes:
browsergym
tobrowsergym-core
in pyproject.tomlAll tests pass successfully, confirming that the core browsergym functionality works as expected.
To run this PR locally, use the following command: