Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove base_path from file actions #320

Merged
merged 2 commits into from
Mar 29, 2024
Merged

remove base_path from file actions #320

merged 2 commits into from
Mar 29, 2024

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Mar 28, 2024

This was putting base_path into the message history, confusing the agent. It'd try and read/write/run things, explicitly specifying the workspace dir

@rbren rbren marked this pull request as ready for review March 28, 2024 20:48
@rbren rbren requested a review from xingyaoww March 28, 2024 20:48
Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Wanted to this for a long time lol

@xingyaoww xingyaoww merged commit 0322693 into main Mar 29, 2024
xcodebuild pushed a commit to xcodebuild/OpenDevin that referenced this pull request Mar 31, 2024
* remove base_path from file actions

* unused imports
@rbren rbren deleted the rb/no-base-path branch April 22, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants