Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global config from sandbox #2961

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Jul 16, 2024

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?

This PR removes direct calls to the global config from the sandbox classes.

Other references

Part of: #2758

@neubig neubig requested review from enyst and xingyaoww July 16, 2024 13:58
Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We just need to fix the sandbox tests

@neubig neubig enabled auto-merge (squash) July 16, 2024 18:13
@neubig neubig merged commit 257698e into main Jul 16, 2024
@neubig neubig deleted the neubig/remove_config_from_sandbox branch July 16, 2024 18:34
RajWorking added a commit to RajWorking/OpenHands that referenced this pull request Jul 19, 2024
yufansong pushed a commit that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants