-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: event stream based agent history #2709
Conversation
54236ca
to
8c1859a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing efforts! Really hoping we can merge it soon - recently we did some big refractor on the eval inference side that might break this.. Lmk if there's anything i can help to fix the merge conflicts!
c32ed9e
to
c82fb14
Compare
tests/integration/mock/DelegatorAgent/test_write_simple_script/prompt_002.log
Show resolved
Hide resolved
c82fb14
to
b84a382
Compare
@xingyaoww Totally agree, I think it will be better to get this one in, sooner rather than later, because we need this architecture to continue building on. Merge conflicts fixed, and it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Got no blockers, but a couple of nits. 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this briefly, but from my check it looks good!
Memory component: short overview
This PR works with the short term history. It proposes an implementation of the event-stream based architecture for agent history, which:
state.history
)cause
set to the actionid
Pre-requisite for #2021