Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse the same IntersectionObserver for all components #25 #71

Merged
merged 1 commit into from
May 24, 2020
Merged

Reuse the same IntersectionObserver for all components #25 #71

merged 1 commit into from
May 24, 2020

Conversation

fmmoret
Copy link
Contributor

@fmmoret fmmoret commented May 23, 2020

Fixes #
#25

Description
Minimizes the number of intersection observers created. Shares intersection observers between components that share the same threshold.

Copy link
Owner

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @fmmoret! Everything works perfectly and code looks good as well. 👌

I will merge it right-away and hopefully will release a beta version next week

@Aljullu Aljullu merged commit 930a18b into Aljullu:master May 24, 2020
@Aljullu Aljullu linked an issue May 24, 2020 that may be closed by this pull request
@fmmoret
Copy link
Contributor Author

fmmoret commented May 28, 2020

👍 would love new version so I can point at it instead of my forked version.

Glad I could help.

@Aljullu
Copy link
Owner

Aljullu commented May 29, 2020

I just released a beta version so we can get some testing before a stable release. Hope it helps:

Thanks again for working on this @fmmoret!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse the same IntersectionObserver for all components
2 participants