Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: finish resize interface #931

Merged

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: Michael Wan [email protected]

Ⅰ. Describe what this PR did

finish resize interface: resize the size of TTY running in the container

root@osboxes:wanziren -> pouch --width 10 --height 10 resize test1
root@osboxes:wanziren ->

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Mar 20, 2018

Codecov Report

Merging #931 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
- Coverage   13.45%   13.42%   -0.03%     
==========================================
  Files         122      122              
  Lines        8000     8015      +15     
==========================================
  Hits         1076     1076              
- Misses       6828     6843      +15     
  Partials       96       96
Impacted Files Coverage Δ
daemon/mgr/container.go 2.3% <0%> (-0.03%) ⬇️
client/container.go 0% <0%> (ø) ⬆️
ctrd/container.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890bdca...5de6fa8. Read the comment docs.

@allencloud
Copy link
Collaborator

I am afraid that resize could be an API located in the daemon side. While we need to think carefully that if it is necessary to take this API into a client side command.
I think sigma has used this API, while not in the way of client command, right?
@furykerry @HusterWan

@HusterWan HusterWan force-pushed the zr/finish-resize-interface branch from c8f5536 to 5de6fa8 Compare March 21, 2018 02:55
@pouchrobot pouchrobot added size/L and removed size/XL labels Mar 21, 2018
@allencloud
Copy link
Collaborator

In the PR description, you mentioned pouch --width 10 --height 10 resize test1.
Is it correct? Should it be pouch resize --width 10 --height 10 test1 since the flags are for the subcommand resize, right?

@HusterWan
Copy link
Contributor Author

@allencloud Yes, the --height and --width is the flags of subcommand, but pouch --width 10 --height 10 resize test1 is also work. :)

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 22, 2018
@allencloud allencloud merged commit 079a92d into AliyunContainerService:master Mar 22, 2018
@allencloud
Copy link
Collaborator

So I think we have removed the cli command part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants