-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: finish resize interface #931
feature: finish resize interface #931
Conversation
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
- Coverage 13.45% 13.42% -0.03%
==========================================
Files 122 122
Lines 8000 8015 +15
==========================================
Hits 1076 1076
- Misses 6828 6843 +15
Partials 96 96
Continue to review full report at Codecov.
|
I am afraid that resize could be an API located in the daemon side. While we need to think carefully that if it is necessary to take this API into a client side command. |
Signed-off-by: Michael Wan <[email protected]>
c8f5536
to
5de6fa8
Compare
In the PR description, you mentioned |
@allencloud Yes, the |
LGTM |
So I think we have removed the cli command part. |
Signed-off-by: Michael Wan [email protected]
Ⅰ. Describe what this PR did
finish resize interface: resize the size of TTY running in the container
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews