Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: cri manager could get the log of container #928

Merged

Conversation

YaoZengzeng
Copy link
Contributor

Signed-off-by: YaoZengzeng [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes part of #420

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Mar 20, 2018

Codecov Report

Merging #928 into master will decrease coverage by 0.1%.
The diff coverage is 1.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
- Coverage   13.49%   13.39%   -0.11%     
==========================================
  Files         121      122       +1     
  Lines        7764     7832      +68     
==========================================
+ Hits         1048     1049       +1     
- Misses       6626     6692      +66     
- Partials       90       91       +1
Impacted Files Coverage Δ
daemon/mgr/container_types.go 15.38% <ø> (ø) ⬆️
daemon/mgr/container.go 2.39% <0%> (-0.02%) ⬇️
daemon/mgr/cri.go 0% <0%> (ø) ⬆️
daemon/containerio/options.go 0% <0%> (ø) ⬆️
daemon/containerio/cri_log_file.go 2.22% <2.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9b22e...ea0c606. Read the comment docs.

@YaoZengzeng
Copy link
Contributor Author

@allencloud PTAL.

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 20, 2018
@allencloud allencloud merged commit ffbbb44 into AliyunContainerService:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/log kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants