Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support Installing pouch on various distributions #681

Closed
wants to merge 2 commits into from

Conversation

zzchun
Copy link
Contributor

@zzchun zzchun commented Feb 1, 2018

Signed-off-by: Zhanchun Zhang [email protected]

1.Describe what this PR did
build rpm and deb packages for pouch

2.Does this pull request fix one issue?
fixes #67

3.Describe how you did it

4.Describe how to verify it

5.Special notes for reviews

Signed-off-by: Zhanchun Zhang <[email protected]>
@Letty5411
Copy link
Contributor

The CRI tests failed because CRI_FOCUS="" and CRI_SKIP="", all tests are run. We may need to fix this in branch 0.1.0. WDYT @allencloud

@allencloud allencloud added this to the v0.2-milestone milestone Feb 2, 2018
@allencloud
Copy link
Collaborator

Do we need to push these files to the master branch? @zzchun

@allencloud
Copy link
Collaborator

The CRI tests failed because CRI_FOCUS="" and CRI_SKIP="", all tests are run. We may need to fix this in branch 0.1.0.

I am afraid my answer is no. Actually we could fix them in master, and make sure the 0.2.x will never have the same issue. This work does not need us to do backporting. @zzchun @Letty5411

So maybe pushing to master is what we need urgently. If we can reach consensus, let us kick the ball ASAP.

@zzchun
Copy link
Contributor Author

zzchun commented Feb 4, 2018

@allencloud these files have been merged to the master branch , I am trying push to 0.1.x now

@allencloud
Copy link
Collaborator

I think we have not ubuntu distribution's installing Pouch yet. Could you first complete https://github.com/alibaba/pouch/blob/master/INSTALLATION.md#ubuntu first. I think this is really important for our users. @zzchun

@allencloud allencloud removed this from the v0.2-milestone milestone Feb 26, 2018
@allencloud
Copy link
Collaborator

I think this could be closed, right. Since we will never update 0.1.x branch. And we will remove this branch soon. Right?
If you confirmed this, please close this PR. Thanks. @zzchun

@zzchun zzchun closed this Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants