-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: implement execSync of cri manager #629
feature: implement execSync of cri manager #629
Conversation
Signed-off-by: YaoZengzeng <[email protected]>
@allencloud PTAL. It has already passed the corresponding test in cri-tools. Since #617 has not been merged, we could not add |
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
- Coverage 13.47% 13.41% -0.07%
==========================================
Files 65 65
Lines 3719 3736 +17
==========================================
Hits 501 501
- Misses 3168 3185 +17
Partials 50 50
Continue to review full report at Codecov.
|
LGTM |
I think we still have some tiny issues in #617, so maybe we need some time fix this. More feature demand, you may refer to @zeppp . We can communicate with each other any time. |
OK. I will do this in two days @allencloud |
Thanks @0x04C2 |
Signed-off-by: YaoZengzeng [email protected]
1.Describe what this PR did
2.Does this pull request fix one issue?
fixes part of #420
3.Describe how you did it
4.Describe how to verify it
Maybe the cri-tools is what you need.
We may use the following method to verify that we can execSyn container:
5.Special notes for reviews