Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unknown command "ls" for "pouch images" #620

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

tiny1990
Copy link
Contributor

1.Describe what this PR did
fix doc
2.Does this pull request fix one issue?

NONE
3.Describe how you did it
source code build and ./pouch images ls
4.Describe how to verify it
NONE

@pouchrobot pouchrobot added areas/cli kind/bug This is bug report for project size/XS labels Jan 22, 2018
@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @tiny1990
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2018

CLA assistant check
All committers have signed the CLA.

@fuweid
Copy link
Contributor

fuweid commented Jan 22, 2018

Hi @tiny1990 , the pouch images is expected command. This command doesn't need the ls.

@codecov-io
Copy link

codecov-io commented Jan 22, 2018

Codecov Report

Merging #620 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #620   +/-   ##
=======================================
  Coverage   13.58%   13.58%           
=======================================
  Files          65       65           
  Lines        3541     3541           
=======================================
  Hits          481      481           
  Misses       3010     3010           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bc4943...2f670cc. Read the comment docs.

@tiny1990
Copy link
Contributor Author

@0x04C2 so i delete ls .

@fuweid
Copy link
Contributor

fuweid commented Jan 22, 2018

Sorry, I make a mistake... Good catch!!!!

@tiny1990
Copy link
Contributor Author

@0x04C2 a hello world pull request

@Letty5411 Letty5411 changed the title Error: unknown command "ls" for "pouch images" fix: unknown command "ls" for "pouch images" Jan 22, 2018
@Letty5411
Copy link
Contributor

@tiny1990 Could you change your commit message with title "fix: " ?

@tiny1990
Copy link
Contributor Author

@Letty5411 change to refactor?

@fuweid
Copy link
Contributor

fuweid commented Jan 22, 2018

Hi @tiny1990 , please use the following command to update your commit message:

git commit -s --amend

And git push -f origin master

@tiny1990
Copy link
Contributor Author

@0x04C2 thanks

@Letty5411
Copy link
Contributor

@tiny1990 change to fix is OK.

@Letty5411
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jan 22, 2018
@Letty5411 Letty5411 merged commit ebf8cc1 into AliyunContainerService:master Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/cli kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants