-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: implement ContainerStatus and PodSandboxStatus of cri manager #573
feature: implement ContainerStatus and PodSandboxStatus of cri manager #573
Conversation
@allencloud PTAL. |
Signed-off-by: YaoZengzeng <[email protected]>
a2d7eb5
to
19aba92
Compare
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
==========================================
- Coverage 14.16% 13.92% -0.25%
==========================================
Files 64 64
Lines 3226 3318 +92
==========================================
+ Hits 457 462 +5
- Misses 2722 2808 +86
- Partials 47 48 +1
Continue to review full report at Codecov.
|
Do we add test case in critools? @YaoZengzeng |
@allencloud It's ok for pouch to pass all the basic sandbox and container operation test in cri-tools if the image is ready. So please to merge this one 😄 |
@@ -25,6 +25,22 @@ func TestParseUint32(t *testing.T) { | |||
} | |||
} | |||
|
|||
func TestToCriTimestamp(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some unit test cases to those returning a non-nil cases.
Maybe in a follow-up.
LGTM |
Signed-off-by: YaoZengzeng [email protected]
1.Describe what this PR did
2.Does this pull request fix one issue?
fixes part of #420
3.Describe how you did it
4.Describe how to verify it
Maybe the cri-tools is what you need.
We may use the following method to verify that we can get status of sandboxes and containers:
5.Special notes for reviews