-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: implement ListPodSandbox method of cri manager #551
feature: implement ListPodSandbox method of cri manager #551
Conversation
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
==========================================
- Coverage 14.16% 14.12% -0.05%
==========================================
Files 64 64
Lines 3226 3278 +52
==========================================
+ Hits 457 463 +6
- Misses 2722 2768 +46
Partials 47 47
Continue to review full report at Codecov.
|
067a7b8
to
7f016c3
Compare
@allencloud PTAL. |
daemon/mgr/cri_test.go
Outdated
@@ -66,6 +66,21 @@ func TestSandboxNameRoundTrip(t *testing.T) { | |||
assert.Equal(t, config.Metadata, actualMetadata) | |||
} | |||
|
|||
func TestConvertPouchStatusToCriSandboxState(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use TestToCriSandboxState
? This is sufficient, I think.
Signed-off-by: YaoZengzeng <[email protected]>
7f016c3
to
2906de4
Compare
@allencloud updated. |
LGTM |
Signed-off-by: YaoZengzeng [email protected]
1.Describe what this PR did
fixes part of #420
2.Does this pull request fix one issue?
3.Describe how you did it
4.Describe how to verify it
Maybe the cri-tools is what you need.
We may use the following method to verify that we can list sandboxes:
5.Special notes for reviews