-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: implement RemoveImage and ImageStatus methods for cri manager #496
feature: implement RemoveImage and ImageStatus methods for cri manager #496
Conversation
Signed-off-by: zeppp <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
==========================================
- Coverage 18.48% 18.34% -0.15%
==========================================
Files 34 34
Lines 1747 1761 +14
==========================================
Hits 323 323
- Misses 1389 1403 +14
Partials 35 35
Continue to review full report at Codecov.
|
@@ -290,7 +290,18 @@ func (c *CriManager) ListImages(ctx context.Context, r *runtime.ListImagesReques | |||
|
|||
// ImageStatus returns the status of the image, returns nil if the image isn't present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the status of image mean? The existence of the image, or the ImageInfo as meta data of image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ImageStatus
will return the Basic information about a container image includes "ID" and "Size" and extra information about the image if needed. Also, if the image isn't present,it will return nil.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 4.Describe how to verify it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is some kind of weird to use status, Maybe info is better. Not blocking this pr.
LGTM |
Signed-off-by: zeppp [email protected]
1.Describe what this PR did
implement RemoveImage and ImageStatus methods for cri manager
2.Does this pull request fix one issue?
fixes part of #420
3.Describe how you did it
4.Describe how to verify it
Use cri-tools to check.
5.Special notes for reviews