feature: implement PullImage and ListImages methods for cri manager #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skoo87 @allencloud PTAL. |
allencloud
reviewed
Jan 2, 2018
daemon/mgr/cri.go
Outdated
| @@ -247,9 +249,41 @@ func (c *CriManager) Status(ctx context.Context, r *runtime.StatusRequest) (*run | |||
| return nil, fmt.Errorf("Status Not Implemented Yet") | |||
| } | |||
|
|
|||
| func imageToRuntimeAPIImage(image *apitypes.ImageInfo) (*runtime.Image, error) { | |||
There was a problem hiding this comment.
Could you add a comment for this function?
Actually I have no strong idea about RuntimeAPIImage.
Thanks. 😄
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
=========================================
Coverage ? 19.07%
=========================================
Files ? 34
Lines ? 1693
Branches ? 0
=========================================
Hits ? 323
Misses ? 1335
Partials ? 35
Continue to review full report at Codecov.
|
YaoZengzeng
force-pushed
the
pull-list-images
branch
3 times, most recently
from
abcb4d1 to
dc1df7b
Compare
Signed-off-by: YaoZengzeng <[email protected]>
YaoZengzeng
force-pushed
the
pull-list-images
branch
from
dc1df7b to
f8de509
Compare
|
@allencloud updated. |
allencloud
reviewed
Jan 2, 2018
| @@ -259,7 +294,24 @@ func (c *CriManager) ImageStatus(ctx context.Context, r *runtime.ImageStatusRequ | |||
|
|
|||
| // PullImage pulls an image with authentication config. | |||
| func (c *CriManager) PullImage(ctx context.Context, r *runtime.PullImageRequest) (*runtime.PullImageResponse, error) { | |||
| return nil, fmt.Errorf("PullImage Not Implemented Yet") | |||
| // TODO: authentication. | |||
| imageRef := r.GetImage().GetImage() | |||
There was a problem hiding this comment.
It makes feel weird, although it is correct totally. 😄
double GetImage().
|
LGTM, I think we could begin considering adding API integration test. @YaoZengzeng @Letty5411 |
pouchrobot
added
the
LGTM
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
1.Describe what this PR did
2.Does this pull request fix one issue?
fixes part of #420
3.Describe how you did it
4.Describe how to verify it
Maybe the cri-tools is what you need.
We may use the following method to verify that we can pull and list images:
5.Special notes for reviews