Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update requirement about golang and linux kernel #2439

Merged
merged 1 commit into from
Nov 8, 2018
Merged

doc: update requirement about golang and linux kernel #2439

merged 1 commit into from
Nov 8, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Nov 6, 2018

Signed-off-by: Wei Fu [email protected]

Ⅰ. Describe what this PR did

Users might run into the issue caused by the kernel. I update the document about the requirement from pouchcontainer. Hope it can help.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

NONE

Ⅴ. Special notes for reviews

Next PR will check the plugin status for containerd. If it's not health, we should shutdown the pouchd.

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #2439 into master will increase coverage by 11.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2439      +/-   ##
==========================================
+ Coverage   57.26%   68.77%   +11.5%     
==========================================
  Files         277      276       -1     
  Lines       18227    18252      +25     
==========================================
+ Hits        10437    12552    +2115     
+ Misses       6582     4276    -2306     
- Partials     1208     1424     +216
Flag Coverage Δ
#criv1alpha1test 31.52% <ø> (-0.1%) ⬇️
#criv1alpha2test 35.61% <ø> (-0.13%) ⬇️
#integrationtest 40.1% <ø> (?)
#nodee2etest 32.91% <ø> (-0.21%) ⬇️
#unittest 26.58% <ø> (+0.04%) ⬆️
Impacted Files Coverage Δ
cri/ocicni/cni_manager.go 59.18% <0%> (-12.25%) ⬇️
storage/volume/modules/tmpfs/tmpfs.go 12.82% <0%> (-3.31%) ⬇️
storage/quota/quota.go 45.04% <0%> (-1.91%) ⬇️
cri/v1alpha2/cri.go 67.51% <0%> (-0.61%) ⬇️
cri/v1alpha2/cri_utils.go 90.92% <0%> (-0.59%) ⬇️
cri/v1alpha1/cri.go 60.59% <0%> (-0.34%) ⬇️
storage/volume/types/meta/meta.go 0% <0%> (ø) ⬆️
cri/v1alpha2/cri_wrapper.go 63.6% <0%> (ø) ⬆️
storage/quota/prjquota.go 27.51% <0%> (ø) ⬆️
storage/quota/grpquota.go 0% <0%> (ø) ⬆️
... and 85 more

@fuweid fuweid changed the title testing [WIP] testing Nov 6, 2018
@fuweid fuweid changed the title [WIP] testing doc: update requirement about golang and linux kernel Nov 7, 2018
@allencloud
Copy link
Collaborator

Could you also please change:

// versionExample shows examples in version command, and is used in auto-generated cli docs.
func versionExample() string {
	return `$ pouch version
GoVersion:       go1.9.1
KernelVersion:   3.10.0-693.11.6.el7.x86_64
Os:              linux
Version:         0.1.0-dev
APIVersion:      1.24
Arch:            amd64
BuildTime:       2017-12-18T07:48:56.348129663Z
GitCommit:
`
}

and it will show more official. @fuweid

1. use golang 1.10.4
2. describe the requirement for the linux kernel
3. update versionExample

Signed-off-by: Wei Fu <[email protected]>
@pouchrobot pouchrobot added size/S and removed size/XS labels Nov 7, 2018
@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Nov 8, 2018
@allencloud allencloud merged commit 55ca859 into AliyunContainerService:master Nov 8, 2018
@fuweid fuweid deleted the update_doc branch November 8, 2018 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/docs areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants