bugfix: fix deadcode reports by gometalinter #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2426 +/- ##
==========================================
+ Coverage 68.35% 68.77% +0.42%
==========================================
Files 272 272
Lines 18206 18155 -51
==========================================
+ Hits 12445 12487 +42
+ Misses 4332 4254 -78
+ Partials 1429 1414 -15
|
|
code check fails with the error: Please take a look. |
updated. |
allencloud
reviewed
Nov 5, 2018
test/util_api.go
Outdated
| @@ -150,15 +141,6 @@ func PauseContainerOk(c *check.C, cname string) { | |||
| CheckRespStatus(c, resp, 204) | |||
| } | |||
|
|
|||
| // UnpauseContainerOk unpauses the container and asserts success.. | |||
There was a problem hiding this comment.
For this part, I do not think removal of code is a good idea. Instead, I am afraid that we should try to take advantages of that in the test code, like:
// unpause it
resp, err = request.Post("/containers/" + cname + "/unpause")
c.Assert(err, check.IsNil)
CheckRespStatus(c, resp, 204)
WDYT? @ZYecho
There was a problem hiding this comment.
In addition, maybe in another pr, we could use PauseContainerOk to replace
resp, err := request.Post("/containers/" + cname + "/pause")
c.Assert(err, check.IsNil)
CheckRespStatus(c, resp, 204)
There was a problem hiding this comment.
good catch, replace it in the next patch.
ZYecho
force-pushed
the
fix-deadcode
branch
2 times, most recently
from
aadc4ea to
cf12a38
Compare
HusterWan
reviewed
Nov 5, 2018
ctrd/utils.go
Outdated
| "net" | ||
| "net/http" | ||
| "time" | ||
|
|
||
| "github.com/alibaba/pouch/apis/types" | ||
| "github.com/alibaba/pouch/pkg/errtypes" | ||
| "github.com/alibaba/pouch/pkg/utils" | ||
|
|
There was a problem hiding this comment.
Keep the blank line, thanks
allencloud
reviewed
Nov 5, 2018
| @@ -373,45 +373,17 @@ func setupNamespaces(ctx context.Context, c *Container, specWrapper *SpecWrapper | |||
| return setupUtsNamespace(ctx, c, specWrapper) | |||
| } | |||
|
|
|||
| // isEmpty indicates whether namespace mode is empty. | |||
There was a problem hiding this comment.
cc @Ace-Tang to check this part.
allencloud
reviewed
Nov 5, 2018
| @@ -258,23 +257,6 @@ func initLog() { | |||
| logrus.SetFormatter(formatter) | |||
| } | |||
|
|
|||
| // define lxcfs processe. | |||
| func setLxcfsProcess(processes exec.Processes) exec.Processes { | |||
There was a problem hiding this comment.
cc @CodeJuan to check lxcfs part.
allencloud
reviewed
Nov 5, 2018
allencloud
reviewed
Nov 5, 2018
| @@ -18,10 +18,6 @@ import ( | |||
| "github.com/sirupsen/logrus" | |||
| ) | |||
|
|
|||
| var ( | |||
There was a problem hiding this comment.
cc @rudyfly to check quota part.
Signed-off-by: zhangyue <[email protected]>
|
LGTM |
pouchrobot
added
the
LGTM
|
Thanks a lot for your work. @ZYecho This will definitely decrease the maintenance effort. And please help continue a followup pr to take advantages of common code in the test code, like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhangyue [email protected]
Ⅰ. Describe what this PR did
As the title desc.
Ⅱ. Does this pull request fix one issue?
fix #2423
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
None.
Ⅳ. Describe how to verify it
None.
Ⅴ. Special notes for reviews
The go tool's report about the deadcode have many errors, such as
PullImageandinspectFilterfunc obviously being used in other code, maybe caused by lacking of--testsopt when use gometalinter.I have double-check based on the reports.
updated:
still have errors even if use
gometalinter --tests --enable=deadcode ./...more deadcode not included in the report, such as
rootFSToAPITypeinpouch/ctrd/utils.go