Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix usage in Run pouch command with non-root users #2344

Merged
merged 1 commit into from
Oct 23, 2018
Merged

docs: fix usage in Run pouch command with non-root users #2344

merged 1 commit into from
Oct 23, 2018

Conversation

flyer103
Copy link
Contributor

@flyer103 flyer103 commented Oct 23, 2018

Ⅰ. Describe what this PR did

Fix usage of Run pouch command with non-root users in INSTALLATION.md.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

It only modifies docs.

Ⅳ. Describe how to verify it

In a brand-new linux environment, do as Run pouch command with non-root users in INSTALLATION.md.

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

❗ No coverage uploaded for pull request head (doc-fix@4092a31). Click here to learn what that means.
The diff coverage is n/a.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @flyer103
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@allencloud
Copy link
Collaborator

Could you help to take a review for this? Thanks a lot. @Ace-Tang

@fuweid
Copy link
Contributor

fuweid commented Oct 23, 2018

@flyer103 please add your sign-off by git commit -s --amend and git push -f origin xxx. Thanks

@fuweid
Copy link
Contributor

fuweid commented Oct 23, 2018

sorry to ping @flyer103 you again because the git commit message is not complete. Could you update it?

@flyer103
Copy link
Contributor Author

@fuweid Done. Sorry for my carelessness.

@Ace-Tang
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Oct 23, 2018
@fuweid
Copy link
Contributor

fuweid commented Oct 23, 2018

the failed case is not caused by this change.
LGTM

@fuweid fuweid merged commit b9787dd into AliyunContainerService:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/cli areas/docs LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants