bugfix: can't allow attach in non-tty client when container in ttyMode #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2338 +/- ##
===========================================
+ Coverage 55.6% 67.97% +12.37%
===========================================
Files 265 265
Lines 18208 18208
===========================================
+ Hits 10124 12377 +2253
+ Misses 6889 4401 -2488
- Partials 1195 1430 +235
|
ZYecho
force-pushed
the
start-more-check
branch
from
84f1e9e to
7201237
Compare
fuweid
reviewed
Oct 23, 2018
|
@ZYecho , the title not tell where is wrong, wdyt? |
ZYecho
force-pushed
the
start-more-check
branch
from
7201237 to
e3af012
Compare
ZYecho
changed the title
Yeah, I update the description of the pr, does fix it? |
ZYecho
changed the title
ZYecho
force-pushed
the
start-more-check
branch
from
e3af012 to
e9af8e9
Compare
Signed-off-by: zhangyue <[email protected]>
ZYecho
force-pushed
the
start-more-check
branch
from
e9af8e9 to
649357f
Compare
|
@ZYecho could you mind to help us to fix the same issue in the exec command? 😄 thanks |
This was referenced Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhangyue [email protected]
Ⅰ. Describe what this PR did
As the title told. The current implementation have two problems:
Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
add an integration test TestStartInTTY.
Ⅳ. Describe how to verify it
None.
Ⅴ. Special notes for reviews
run cli also have same problems, will fix in another pr.