Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: several change #2320

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

zhuangqh
Copy link
Contributor

Signed-off-by: zhuangqh [email protected]

Ⅰ. Describe what this PR did

some minor change

  • add timeout to server
  • log exec info

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #2320 into master will increase coverage by 0.08%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2320      +/-   ##
==========================================
+ Coverage   67.38%   67.47%   +0.08%     
==========================================
  Files         217      218       +1     
  Lines       17650    17664      +14     
==========================================
+ Hits        11893    11918      +25     
+ Misses       4356     4354       -2     
+ Partials     1401     1392       -9
Flag Coverage Δ
#criv1alpha1test 32.25% <57.14%> (-0.01%) ⬇️
#criv1alpha2test 36.42% <57.14%> (+0.19%) ⬆️
#integrationtest 40.45% <71.42%> (+0.01%) ⬆️
#nodee2etest 33.8% <57.14%> (+0.27%) ⬆️
#unittest 23.26% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
apis/server/log_filter_writer.go 0% <0%> (ø)
apis/server/exec_bridge.go 52.45% <100%> (+1.61%) ⬆️
apis/server/server.go 58.69% <100%> (+6.19%) ⬆️
daemon/mgr/container_utils.go 84.04% <100%> (-0.29%) ⬇️
ctrd/watch.go 75.75% <0%> (-4.55%) ⬇️
daemon/containerio/cio.go 60.15% <0%> (-2.35%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
daemon/mgr/container.go 59.21% <0%> (+0.21%) ⬆️
cri/v1alpha2/cri_utils.go 90.57% <0%> (+0.28%) ⬆️
... and 5 more

@zhuangqh zhuangqh force-pushed the refactor-minor branch 2 times, most recently from 36054b0 to e6e13a9 Compare October 18, 2018 01:25
@pouchrobot pouchrobot added size/M and removed size/S labels Oct 18, 2018
@fuweid
Copy link
Contributor

fuweid commented Oct 18, 2018

LGTM

@fuweid fuweid merged commit f417382 into AliyunContainerService:master Oct 18, 2018
@zhuangqh zhuangqh deleted the refactor-minor branch October 31, 2018 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants