Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add $GOPATH/bin to PATH environment variable for root user. #2246

Merged
merged 1 commit into from
Sep 18, 2018
Merged

add $GOPATH/bin to PATH environment variable for root user. #2246

merged 1 commit into from
Sep 18, 2018

Conversation

manlge
Copy link
Contributor

@manlge manlge commented Sep 17, 2018 •
edited by allencloud
Loading

Signed-off-by: Mark Liu [email protected]

Ⅰ. Describe what this PR did

With vagrant, developers don't need to manually configure the PATH environment variable.

$ vagrant ssh -c "sudo -i"
$ go get -u github.com/derekparker/delve/cmd/dlv
$ dlv version
Delve Debugger
Version: 1.1.0
Build: $Id: 1990ba12450cab9425a2ae62e6ab988725023d5c

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)

none

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

fuweid
fuweid reviewed Sep 18, 2018
View reviewed changes
Vagrantfile
@@ -34,18 +34,20 @@ Vagrant.configure("2") do |config|
pouch.vm.provision "shell", inline: <<-SHELL
# configring environments for pouch
GO_VERSION=1.9.1
GOROOT=/opt/go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we set the GOROOT here?

Copy link
Contributor Author

@manlge manlge Sep 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tar xf /tmp/go$GO_VERSION.linux-amd64.tar.gz -C /opt/
Where do you recommend?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well. basically, when we install the go, the GOROOT will be in go env.

fuweid
fuweid reviewed Sep 18, 2018
View reviewed changes
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 651bc7a into AliyunContainerService:master Sep 18, 2018
@pouchrobot pouchrobot mentioned this pull request Sep 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid left review comments

Assignees

@fuweid fuweid

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manlge @fuweid @pouchrobot