fix: fix cri exec hang #2224
Merged
fix: fix cri exec hang #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouchrobot
added
kind/bug
|
If exec process get run, io should be closed in the function , still have no iead why it can't close backend after function. If io closed after the function, log followed will miss. |
do not return error when execProcess.Start() fail, if exec process started, let execExitedAndRelease do the exit hook. Signed-off-by: Ace-Tang <[email protected]>
HusterWan
reviewed
Sep 11, 2018
| if err := <-fail; err != nil { | ||
| msg.err = err | ||
| // exit code should not be zero when exec get failed. | ||
| if msg.exitCode == 0 { |
There was a problem hiding this comment.
whether it is possible exitCode is not zero when exec got error?
There was a problem hiding this comment.
It possible, like exec $id aaaaa .
HusterWan
reviewed
Sep 12, 2018
| } | ||
| } | ||
| // XXX: if exec process get run, io should be closed in this function, | ||
| for _, hook := range c.hooks { |
There was a problem hiding this comment.
Now, no matter run exec got an error or not, we always call the exit hook.
There was a problem hiding this comment.
yes, when exec start , no matter what result, let hook do the clean. Before exec start, if got error, let pouch daemon level do the clean.
|
lgtm |
pouchrobot
added
the
LGTM
|
@allencloud , merge this after #2226 pass ci. |
|
LGTM |
|
@Ace-Tang All tests has been passed. ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not return error when execProcess.Start() fail, if exec process
started, let execExitedAndRelease do the exit hook.
Signed-off-by: Ace-Tang [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
will add in cri by @starnop .
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews