Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: release 1.0.0-rc2 version #2145

Merged
merged 1 commit into from
Aug 23, 2018
Merged

release: release 1.0.0-rc2 version #2145

merged 1 commit into from
Aug 23, 2018

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Aug 23, 2018

Signed-off-by: Wei Fu [email protected]

Ⅰ. Describe what this PR did

release

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

just change the version

Ⅳ. Describe how to verify it

wait for CI

Ⅴ. Special notes for reviews

Signed-off-by: Wei Fu <[email protected]>
@fuweid fuweid changed the title release: 1.0.0-rc2 release: release 1.0.0-rc2 version Aug 23, 2018
@allencloud
Copy link
Collaborator

allencloud commented Aug 23, 2018

LGTM until the CI passes.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 23, 2018
@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #2145 into master will decrease coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2145      +/-   ##
==========================================
- Coverage   64.38%   63.51%   -0.87%     
==========================================
  Files         209      209              
  Lines       16631    17137     +506     
==========================================
+ Hits        10708    10885     +177     
- Misses       4595     4914     +319     
- Partials     1328     1338      +10
Flag Coverage Δ
#criv1alpha1test 32.95% <ø> (ø) ⬆️
#criv1alpha2test 33.76% <ø> (+0.19%) ⬆️
#integrationtest 39.3% <ø> (+0.04%) ⬆️
#unittest 23.92% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
cri/v1alpha1/cri_utils.go 60.51% <0%> (-22.82%) ⬇️
cri/stream/httpstream/spdy/upgrade.go 54.28% <0%> (-5.72%) ⬇️
cri/v1alpha2/cri_utils.go 78.61% <0%> (-3.75%) ⬇️
cri/v1alpha1/cri.go 61.03% <0%> (-2.67%) ⬇️
cri/v1alpha2/cri.go 63.91% <0%> (-0.84%) ⬇️
daemon/mgr/container.go 56.65% <0%> (+0.2%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
ctrd/image.go 76.75% <0%> (+1.75%) ⬆️
apis/server/utils.go 66.66% <0%> (+4.76%) ⬆️

@fuweid fuweid merged commit 894a59d into AliyunContainerService:master Aug 23, 2018
@fuweid fuweid deleted the 1.0.0-rc2 branch August 23, 2018 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants