Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test cases about toCNIPortMappings #2050

Conversation

starnop
Copy link
Contributor

@starnop starnop commented Aug 3, 2018

Signed-off-by: Starnop [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes part of #1756

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #2050 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
- Coverage   64.02%   63.98%   -0.04%     
==========================================
  Files         202      202              
  Lines       15510    15510              
==========================================
- Hits         9930     9924       -6     
- Misses       4343     4347       +4     
- Partials     1237     1239       +2
Flag Coverage Δ
#criv1alpha1test 33.75% <ø> (+0.15%) ⬆️
#criv1alpha2test 34.21% <ø> (-0.1%) ⬇️
#integrationtest 38.45% <ø> (-0.05%) ⬇️
#unittest 22.71% <ø> (+0.17%) ⬆️
Impacted Files Coverage Δ
ctrd/watch.go 69.69% <0%> (-6.07%) ⬇️
ctrd/image.go 76.84% <0%> (-1.98%) ⬇️
cri/v1alpha2/cri.go 66.02% <0%> (-0.18%) ⬇️
daemon/mgr/container.go 53.93% <0%> (+0.15%) ⬆️
cri/v1alpha1/cri.go 65.36% <0%> (+0.17%) ⬆️

@starnop starnop force-pushed the cri-test-toCNIPortMappings branch from 79ec668 to 175bc4a Compare August 6, 2018 06:23
@pouchrobot pouchrobot added size/XL and removed size/L labels Aug 6, 2018
@YaoZengzeng
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants