Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

266-1:add testing cri_utils_test.go #1956

Closed
wants to merge 1 commit into from

Conversation

mangodai
Copy link

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1912

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @mangodai
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@mangodai mangodai changed the title add testing cri_utils_test.go 266-1:add testing cri_utils_test.go Jul 31, 2018
@codecov-io
Copy link

Codecov Report

Merging #1956 into master will decrease coverage by 7.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
- Coverage   63.31%   55.84%   -7.48%     
==========================================
  Files         200      200              
  Lines       15522    15522              
==========================================
- Hits         9828     8668    -1160     
- Misses       4455     5617    +1162     
+ Partials     1239     1237       -2
Flag Coverage Δ
#criv1alpha1test 37.58% <ø> (+3.72%) ⬆️
#criv1alpha2test 34.26% <ø> (-0.02%) ⬇️
#integrationtest 38.42% <ø> (-0.02%) ⬇️
#unittest 18.15% <ø> (-2.71%) ⬇️
Impacted Files Coverage Δ
pkg/multierror/def.go 15.38% <0%> (-84.62%) ⬇️
daemon/logger/loggerutils/tag.go 0% <0%> (-81.82%) ⬇️
cri/v1alpha1/cri_stream.go 0% <0%> (-80%) ⬇️
cri/v1alpha1/service/cri.go 0% <0%> (-73.34%) ⬇️
pkg/utils/utils.go 25.64% <0%> (-64.53%) ⬇️
pkg/bytefmt/bytefmt.go 28.81% <0%> (-64.41%) ⬇️
ctrd/image_proxy_util.go 7.81% <0%> (-59.38%) ⬇️
cri/v1alpha1/cri_wrapper.go 0% <0%> (-57.15%) ⬇️
daemon/mgr/container_envs.go 11.76% <0%> (-54.91%) ⬇️
daemon/logger/info.go 0% <0%> (-53.66%) ⬇️
... and 35 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for getSELinuxSecurityOpts
4 participants