Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #1756 partial finished #1879

Closed

Conversation

Inoria-cn
Copy link

bugfix: add missing document in Makefile
Signed-off-by: Inoria-cn [email protected]

Ⅰ. Describe what this PR did

group 9

Ⅱ. Does this pull request fix one issue?

fixes issue #1756

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

bugfix: add missing document in Makefile
Signed-off-by: Inoria-cn <[email protected]>
@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @Inoria-cn
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot pouchrobot added size/M and removed size/XS labels Jul 24, 2018
@pouchrobot
Copy link
Collaborator

@Inoria-cn Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

ping @Inoria-cn
We found that this PR is 34 commits, which is more than 10 commits, behind master.
Please rebase the branch against master and push it back again. Thanks a lot.

@pouchrobot
Copy link
Collaborator

ping @Inoria-cn
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@allencloud allencloud closed this Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants