Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit-test for httpstream's IsUpgradeRequest, negotiateProtocol, Handshake methods #1800

Closed
wants to merge 2 commits into from

Conversation

gfl699468
Copy link
Contributor

@gfl699468 gfl699468 commented Jul 23, 2018

Ⅰ. Describe what this PR did

Add unit-test for httpstream's IsUpgradeRequest, negotiateProtocol, Handshake methods

Ⅱ. Does this pull request fix one issue?

fixes parts of #1756

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

run
go test ./cri/stream/httpstream/httpstream_test.go ./cri/stream/httpstream/httpstream.go

Ⅴ. Special notes for reviews

baiji group 1

@pouchrobot
Copy link
Collaborator

@gfl699468 Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @gfl699468
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

Codecov Report

Merging #1800 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1800     +/-   ##
=========================================
+ Coverage    56.3%   56.51%   +0.2%     
=========================================
  Files         200      200             
  Lines       15657    15657             
=========================================
+ Hits         8816     8848     +32     
+ Misses       5745     5720     -25     
+ Partials     1096     1089      -7
Flag Coverage Δ
#critest 33.52% <ø> (+0.04%) ⬆️
#integrationtest 37.69% <ø> (+0.03%) ⬆️
#unittest 20.48% <ø> (+0.15%) ⬆️
Impacted Files Coverage Δ
ctrd/watch.go 71.87% <0%> (-3.13%) ⬇️
cri/v1alpha2/cri.go 66.13% <0%> (+0.17%) ⬆️
daemon/mgr/container.go 53.46% <0%> (+0.31%) ⬆️
ctrd/container.go 50.17% <0%> (+1.37%) ⬆️
ctrd/image.go 81.18% <0%> (+4.45%) ⬆️
cri/stream/httpstream/httpstream.go 96.29% <0%> (+59.25%) ⬆️

@YaoZengzeng
Copy link
Contributor

We have merged a PR which solve the same problem

Thanks for your work

Close this now :)

@YaoZengzeng YaoZengzeng closed this Aug 1, 2018
@gfl699468 gfl699468 deleted the dev branch August 2, 2018 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants