Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: a typo in CONTRIBUTTING.md #1775

Merged
merged 1 commit into from
Jul 23, 2018
Merged

bugfix: a typo in CONTRIBUTTING.md #1775

merged 1 commit into from
Jul 23, 2018

Conversation

zhuorantan
Copy link
Contributor

@zhuorantan zhuorantan commented Jul 23, 2018

Ⅰ. Describe what this PR did

Fix a typo in CONTRIBUTING.md

Ⅱ. Does this pull request fix one issue?

No

Ⅲ. Describe how you did it

Change "you" to "your"

Ⅳ. Describe how to verify it

English grammar

Ⅴ. Special notes for reviews

Team 10

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot pouchrobot added areas/typo kind/bug This is bug report for project size/XS labels Jul 23, 2018
@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @JeromeTan1997
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@fuweid
Copy link
Contributor

fuweid commented Jul 23, 2018

@JeromeTan1997 Thanks for your contribution. Could you please use the following statement to repush your change?

git commit -s --amend
git push -f origin typo

Thanks

@zhuorantan
Copy link
Contributor Author

@fuweid Done😀

@codecov-io
Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #1775 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1775      +/-   ##
==========================================
+ Coverage   56.32%   56.36%   +0.03%     
==========================================
  Files         200      200              
  Lines       15657    15657              
==========================================
+ Hits         8819     8825       +6     
+ Misses       5742     5739       -3     
+ Partials     1096     1093       -3
Flag Coverage Δ
#critest 33.55% <ø> (+0.07%) ⬆️
#integrationtest 37.65% <ø> (-0.04%) ⬇️
#unittest 20.33% <ø> (ø) ⬆️
Impacted Files Coverage Δ
ctrd/image.go 78.71% <0%> (-0.5%) ⬇️
daemon/mgr/container.go 53.3% <0%> (ø) ⬆️
cri/v1alpha2/cri.go 66.13% <0%> (+0.17%) ⬆️
ctrd/container.go 50.17% <0%> (+1.37%) ⬆️
apis/server/utils.go 66.66% <0%> (+4.76%) ⬆️

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit caabc86 into AliyunContainerService:master Jul 23, 2018
@zhuorantan zhuorantan deleted the typo branch August 4, 2018 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/typo kind/bug This is bug report for project size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants