Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: execConfig remove omitemtpy #1619

Merged

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: Michael Wan [email protected]

Ⅰ. Describe what this PR did

exec inspect return json body align with moby api. delete all omitemtpy flag from ContainerExecInspect

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XL labels Jul 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #1619 into master will increase coverage by <.01%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
+ Coverage   41.97%   41.98%   +<.01%     
==========================================
  Files         270      270              
  Lines       17585    17597      +12     
==========================================
+ Hits         7382     7388       +6     
- Misses       9296     9299       +3     
- Partials      907      910       +3
Impacted Files Coverage Δ
daemon/mgr/container_exec.go 70.11% <86.66%> (+2.11%) ⬆️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
daemon/mgr/container.go 50.19% <0%> (-0.16%) ⬇️

@rudyfly
Copy link
Collaborator

rudyfly commented Jul 4, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 4, 2018
@rudyfly rudyfly merged commit 00f6ea5 into AliyunContainerService:master Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants