fix: rename cpu-share to cpu-shares in command line #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
rename-cpu-shares
branch
from
df680a3 to
f42eef3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1547 +/- ##
=======================================
Coverage 17.68% 17.68%
=======================================
Files 214 214
Lines 14386 14386
=======================================
Hits 2544 2544
Misses 11680 11680
Partials 162 162
|
allencloud
force-pushed
the
rename-cpu-shares
branch
2 times, most recently
from
1bad528 to
f47d46f
Compare
Signed-off-by: Allen Sun <[email protected]>
allencloud
force-pushed
the
rename-cpu-shares
branch
from
f47d46f to
6e0a937
Compare
|
LGTM |
pouchrobot
added
the
LGTM
This was referenced Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
the related command line flag about cpu share should be
--cpu-sharesrather than--cpu-share.This update would be compatible with moby's way.
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Describe how you did it
change the flag file and test
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none