bugfix: we must call Restore container after initialize network Mgr #1422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Wan [email protected]
Ⅰ. Describe what this PR did
fix bug: containerMgr use the networkMgr struct before initialize it that will occur
panic: runtime error: invalid memory address or nil pointer dereference
when start
pouchd
, we will callcontainerMgr.Restore
to restore all running containers, if the container has already exited but disk file record the status isrunning
, we must callmarkStoppedAndRelease
method to clean the container's resources and mark itstopped
.markStoppedAndRelease
method will callcontainerMgr.networkMgr
, so ifnetworkMgr
not initialized, there will painc:Ⅱ. Does this pull request fix one issue?
fixes #1421
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews