Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor return err for golint #1117

Merged
merged 1 commit into from
Apr 12, 2018
Merged

refactor: refactor return err for golint #1117

merged 1 commit into from
Apr 12, 2018

Conversation

oblivionfallout
Copy link

@oblivionfallout oblivionfallout commented Apr 12, 2018

Ⅰ. Describe what this PR did

For Go Report. daemon/mgr/container.go has a golint issue. Remove if and just return err.

Ⅱ. Does this pull request fix one issue?

fixes one part of #964

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #1117 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   16.44%   16.31%   -0.13%     
==========================================
  Files         165      165              
  Lines        8841     8842       +1     
==========================================
- Hits         1454     1443      -11     
- Misses       7283     7295      +12     
  Partials      104      104
Impacted Files Coverage Δ
daemon/mgr/container.go 5% <0%> (ø) ⬆️
pkg/utils/utils.go 78.12% <0%> (+2.48%) ⬆️
daemon/containerio/raw_file.go 4.16% <0%> (+4.16%) ⬆️
pkg/kernel/kernel.go 83.33% <0%> (+10.6%) ⬆️

@allencloud
Copy link
Collaborator

LGTM, thanks a lot for your contribution.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 12, 2018
@allencloud allencloud merged commit 1ef611c into AliyunContainerService:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants