Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tls test #1115

Merged
merged 1 commit into from
Apr 17, 2018
Merged

test: add tls test #1115

merged 1 commit into from
Apr 17, 2018

Conversation

Letty5411
Copy link
Contributor

Signed-off-by: letty [email protected]

Ⅰ. Describe what this PR did

  1. add tls data
  2. add tls test

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Apr 12, 2018

Codecov Report

Merging #1115 into master will increase coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   15.54%   16.27%   +0.73%     
==========================================
  Files         172      164       -8     
  Lines        9739     8865     -874     
==========================================
- Hits         1514     1443      -71     
+ Misses       8116     7318     -798     
+ Partials      109      104       -5
Impacted Files Coverage Δ
cli/inspect/inspector.go 53.52% <0%> (-19.62%) ⬇️
pkg/utils/utils.go 75.64% <0%> (-2.52%) ⬇️
daemon/mgr/container_utils.go 56.19% <0%> (-1.85%) ⬇️
daemon/mgr/system.go 0% <0%> (ø) ⬆️
cli/cli.go 0% <0%> (ø) ⬆️
ctrd/image.go 0% <0%> (ø) ⬆️
cli/main.go 0% <0%> (ø) ⬆️
cli/common_flags.go 0% <0%> (ø) ⬆️
cli/inspect.go 0% <0%> (ø) ⬆️
daemon/mgr/spec_blkio.go 0% <0%> (ø) ⬆️
... and 22 more

@Ace-Tang Ace-Tang requested a review from yyb196 April 13, 2018 08:02
@allencloud
Copy link
Collaborator

Please add another test case which client uses a incorrect certificate and finally the test case fails. I think with positive and negative case the test would be much more meaningful. @Letty5411

Signed-off-by: letty <[email protected]>
@Letty5411
Copy link
Contributor Author

@allencloud add it, PTAL

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 17, 2018
@allencloud allencloud merged commit 2812ca0 into AliyunContainerService:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants