feature: enable setup common name whitelist for tls checking #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HusterWan
reviewed
Apr 2, 2018
main.go
Outdated
| @@ -82,7 +82,8 @@ func setupFlags(cmd *cobra.Command) { | |||
| flagSet.StringVar(&cfg.TLS.Key, "tlskey", "", "Specify key file of TLS") | |||
| flagSet.StringVar(&cfg.TLS.Cert, "tlscert", "", "Specify cert file of TLS") | |||
| flagSet.StringVar(&cfg.TLS.CA, "tlscacert", "", "Specify CA file of TLS") | |||
| flagSet.BoolVar(&cfg.TLS.VerifyRemote, "tlsverify", false, "Use TLS and verify remote") | |||
| flagSet.BoolVar(&cfg.TLS.VerifyRemote, "tlsverify", false, "Use TLS and verify re") | |||
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
==========================================
- Coverage 15.96% 15.71% -0.26%
==========================================
Files 161 139 -22
Lines 8856 8484 -372
==========================================
- Hits 1414 1333 -81
+ Misses 7339 7050 -289
+ Partials 103 101 -2
Continue to review full report at Codecov.
|
allencloud
changed the title
pouchrobot
added
conflict/needs-rebase
size/L
and removed
size/XL
conflict/needs-rebase
labels
|
LGTM |
pouchrobot
added
LGTM
|
I rerun the CI and submitted an issue #1095 to record this flaky test. |
allencloud
reviewed
Apr 11, 2018
apis/server/router.go
Outdated
| s.addRoute(r, http.MethodGet, "/containers/{name:.*}/json", s.getContainer) | ||
| s.addRoute(r, http.MethodDelete, "/containers/{name:.*}", s.removeContainers) | ||
| s.addRoute(r, http.MethodPost, "/containers/{name:.*}/exec", s.createContainerExec) | ||
| s.addRoute(r, http.MethodPost, "/exec/{name:.*}/start", s.startContainerExec) |
There was a problem hiding this comment.
I think it is your missing line of code addRoute(r, http.MethodGet, "/exec/{name:.*}/json", s.getExecInfo) leads to the CI failure.
Signed-off-by: Frank Yang <[email protected]>
|
LGTM |
pouchrobot
added
the
LGTM
|
I am wondering if we add more document in https://github.com/alibaba/pouch/blob/master/docs/features/pouch_with_tls.md to tell people how to use this feature. Thanks. @yyb196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frank Yang [email protected]
Ⅰ. Describe what this PR did
enable setup common name whitelist for tls checking, not all the certificates which recognized by pouchd can connect to pouchd, if
--manager-whitelistis specified only certificates whose common name in the whitelist will be accept by the pouchd.Ⅱ. Does this pull request fix one issue?
close #802
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews