bugfix: change container create output #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
pouchrobot
added
LGTM
|
CI failed， you may also need to change the corresponding tests: |
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
=======================================
Coverage 15.71% 15.71%
=======================================
Files 139 139
Lines 8483 8483
=======================================
Hits 1333 1333
Misses 7050 7050
Partials 100 100
Continue to review full report at Codecov.
|
allencloud
reviewed
Apr 3, 2018
test/cli_create_test.go
Outdated
| res := command.PouchRun("create", "--name", name, busyboxImage) | ||
|
|
||
| res.Assert(c, icmd.Success) | ||
| if out := res.Combined(); !strings.Contains(out, name) { |
There was a problem hiding this comment.
No need to remove all the test case. Maybe we just remove the string comparing.
There was a problem hiding this comment.
That sounds reasonable. Thx.
allencloud
reviewed
Apr 3, 2018
test/cli_create_test.go
Outdated
| res = command.PouchRun("create", "--name", name, imageID) | ||
|
|
||
| res.Assert(c, icmd.Success) | ||
| if out := res.Combined(); !strings.Contains(out, name) { |
There was a problem hiding this comment.
The same as the following review comment.
Signed-off-by: Zou Rui <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zou Rui [email protected]
Ⅰ. Describe what this PR did
change the output of container create
old way:
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews