Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add container rename client side mock test #1021

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

Dewey-Ding
Copy link
Contributor

Signed-off-by: Dewey-Ding [email protected]

Ⅰ. Describe what this PR did

add test for container rename

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2018

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Dewey-Ding <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #1021 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
+ Coverage   14.02%   14.09%   +0.07%     
==========================================
  Files         125      126       +1     
  Lines        8469     8469              
==========================================
+ Hits         1188     1194       +6     
+ Misses       7181     7175       -6     
  Partials      100      100
Impacted Files Coverage Δ
client/container.go 0% <ø> (ø) ⬆️
client/container_rename.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12435f4...535fdb6. Read the comment docs.

@allencloud allencloud changed the title test:add container rename test: add container rename client side mock test Mar 30, 2018
@allencloud
Copy link
Collaborator

LGTM, thanks a lot for your contribution.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 30, 2018
@allencloud allencloud merged commit 330ee95 into AliyunContainerService:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants