Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onedrive): fix timeout error (#7506). #7551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shing-yu
Copy link

@shing-yu shing-yu commented Nov 23, 2024

This PR will close #7506

把自己提的issue修了一下(
没怎么接触过GO,但改文本还是会的(

修改为500和1000的差别不大,都是1m11s左右获取完成(5841个文件)
image

@xhofe
Copy link
Collaborator

xhofe commented Nov 24, 2024

建议提取为驱动的配置项

@shing-yu
Copy link
Author

是个好想法(

@shing-yu
Copy link
Author

但是感觉各个合理值的速率差别不大,而且有可能被误配置导致出现问题

(更重要的是,作为一名高中牲,我现在在学校(((

@shing-yu
Copy link
Author

其实我还是觉得像这个数据不应该放在配置项里:
1. 对于大部分人来说,文件夹里并不会有这么多文件,这种情况下将其改为合理的更小值并不会带来速度的提升
2. 在文件多的情况下,各合理值的速度差别不大
3. 配置项里除了基础信息外,对其他项的修改不应影响驱动的正常使用;且该项配置在不看文档的情况下比较容易被修改为过小值或过大值导致影响驱动的正常工作

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onedrive文件夹内文件过多时响应时间过长导致Timeout
2 participants