Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved data shuffling to just before tokenization step #110

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

levmckinney
Copy link
Collaborator

This is particularly useful for datasets like togethercomputer/RedPajama-Data-1T-Sample that do not come preshuffled. Often the local shuffling done by the dataloader is insufficient for datasets this large.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #110 (7b3172c) into main (51e988b) will decrease coverage by 0.05%.
Report is 6 commits behind head on main.
The diff coverage is 71.42%.

❗ Current head 7b3172c differs from pull request most recent head 21db0bf. Consider uploading reports for the commit 21db0bf to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   81.08%   81.04%   -0.05%     
==========================================
  Files          32       32              
  Lines        2141     2147       +6     
==========================================
+ Hits         1736     1740       +4     
- Misses        405      407       +2     
Files Changed Coverage Δ
tuned_lens/scripts/ingredients.py 85.56% <71.42%> (-0.63%) ⬇️

@levmckinney levmckinney added this to the v1.0.0 milestone Aug 29, 2023
Copy link
Collaborator

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I do want to flag one possible change in default behaviour. IIUC previously you always shuffled after tokenization, and never before tokenizaiton. Now you never shuffle after tokenization, and by default do not shuffle before tokenization. So we have gone from default to some kind of shuffling to default to no kind of shuffling.

I don't have enough context on the codebase to know if this is desirable or not, but do want to make sure it's an intentional change, and you may want to consider documenting it.

@levmckinney levmckinney merged commit 780fcd3 into main Sep 11, 2023
5 of 6 checks passed
@levmckinney levmckinney deleted the dataset-shuffle branch September 11, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants